[openstreetmap/openstreetmap-website] Get directions using fetch (PR #5642)

Tom Hughes notifications at github.com
Tue Feb 11 19:43:20 UTC 2025


@tomhughes commented on this pull request.



>              if (response.code !== "Ok") {
-              return callback(true);
+              throw new TypeError("Response " + response.code);

Sure, but this doesn't really fit the description of `TypeError` at https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypeError does it? So maybe just use `Error` instead?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5642#discussion_r1951491482
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5642/review/2609850943 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250211/ccee4670/attachment.htm>


More information about the rails-dev mailing list