[openstreetmap/openstreetmap-website] Add option to override Firefox binary used in system tests (PR #5672)
Anton Khorev
notifications at github.com
Fri Feb 14 17:17:38 UTC 2025
Addresses #5488 by providing a setting instead of workarounds such as modifying `test/application_system_test_case.rb`.
I'm also using these workarounds and it's annoying because you can accidentally commit them. But if there's a setting, I can put it in some file that's ignored by git, for example in `config/settings/test.local.yml` (assuming tests run in test environment; teaspoon tests by default don't but you can run them with `RAILS_ENV=test bundle exec teaspoon`).
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5672
-- Commit Summary --
* Add option to override Firefox binary used in system tests
-- File Changes --
M config/settings.yml (2)
M test/application_system_test_case.rb (1)
M test/teaspoon_env.rb (4)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/5672.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5672.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5672
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5672 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250214/4e1b91e1/attachment-0001.htm>
More information about the rails-dev
mailing list