[openstreetmap/openstreetmap-website] Remove some unnecessary calls to clear the mail queue (PR #5695)

[Andy Allan]

These were not needed at the end of most tests for quite some time, since rails clears them by default for controller and integration tests, and also no longer required in system tests after #5691

There's still some calls that could be removed, for example by also automatically clearing `job` tests and by slightly reworking one of the mega tests in the `passwords_controller_test`.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5695

-- Commit Summary --

  * Remove some unnecessary calls to clear the mail queue

-- File Changes --

    M test/controllers/accounts_controller_test.rb (1)
    M test/controllers/api/changeset_comments_controller_test.rb (4)
    M test/controllers/api/notes_controller_test.rb (4)
    M test/controllers/confirmations_controller_test.rb (2)
    M test/controllers/diary_comments_controller_test.rb (2)
    M test/controllers/follows_controller_test.rb (2)
    M test/controllers/messages_controller_test.rb (2)
    M test/controllers/passwords_controller_test.rb (1)
    M test/controllers/users_controller_test.rb (4)
    M test/integration/user_creation_test.rb (49)
    M test/system/user_email_change_test.rb (2)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5695.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5695.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5695
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5695 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250216/67dcf725/attachment-0001.htm>