[openstreetmap/openstreetmap-website] Copies notes details from first comments to notes table (PR #5667)
Nenad Vujicic
notifications at github.com
Mon Feb 17 09:45:23 UTC 2025
nenad-vujicic left a comment (openstreetmap/openstreetmap-website#5667)
> I would also interested in what the next step will be.
At the moment, the plan is following:
1. Perform data migration
2. If we succeeded to migrate all notes, remove optional using records from first special comment, otherwise we'll have to leave some fallback mechanism
3. Create DB table `old_notes` which will store note versions and update Note model with appropriate associations
- This will be decomposed into several PRs
- Perhaps this is good place to discuss how to apply #5619 to notes tables (perhaps use `notes_versions` instead of `old_notes`?)
4. Add creating versions on notes actions (create, reopen, close, ..)
5. Populate `note_versions` from `note_comments`
6. Create helper routine which will generate list of comments (i.e. discussion, used in left side-bar, rss feed, xml / json files, ..) from `note_versions` table and from `note_comments` table (but using only note comments with non-blank bodies
7. Replace displaying / using discussions with helper routine
8. Remove column `event` from `note_comments` table and comments with blank bodies
9. .. continue with adding note tags ..
I'm aware this plan is full of flaws and there are multiple points which should be further discussed / defined, so everyone's comment is very welcome!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5667#issuecomment-2662571772
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5667/c2662571772 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250217/bb3899f6/attachment.htm>
More information about the rails-dev
mailing list