[openstreetmap/openstreetmap-website] Displays "unknown" description for notes with missing opening comment (PR #5712)

Nenad Vujicic notifications at github.com
Wed Feb 19 21:54:53 UTC 2025


### Description

It seems there are some notes in database with a missing opening comment ([here](https://github.com/openstreetmap/openstreetmap-website/pull/5667#discussion_r1957131929)). This PR adds displaying "unknown" as description for such notes and remaining comments (if available) as part of discussion.

### How has this been tested?

Automatic and manual testing before and after [data migration](https://github.com/openstreetmap/openstreetmap-website/pull/5667#issuecomment-2659190584).
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5712

-- Commit Summary --

  * Improves notes_description helper routine
  * Improves behavior if note lacks opening comment
  * Improves dropping of first note's comment

-- File Changes --

    M app/controllers/notes_controller.rb (2)
    M app/helpers/note_helper.rb (2)
    M app/models/note.rb (4)
    M config/locales/en.yml (1)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5712.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5712.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5712
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5712 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250219/70006638/attachment-0001.htm>


More information about the rails-dev mailing list