[openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

David Tsiklauri notifications at github.com
Thu Feb 20 07:18:14 UTC 2025


@nertc commented on this pull request.



> @@ -10,6 +10,35 @@ $(document).ready(function () {
   var defaultHomeZoom = 12;
   var map, marker, deleted_lat, deleted_lon;
 
+  if ($("#social_links").length) {
+    $("#add-social-link").click(function (event) {
+      event.preventDefault();
+      const newIndex = -Date.now();
+      const socialLinkForm = $(`
+        <div class="social-link-added-fields row mb-3">
+          <div class="col-sm-8">
+            <input class="form-control" type="text" name="user[social_links_attributes][${newIndex}][url]" id="user_social_links_attributes_${newIndex}_url">      
+          </div>
+          <button type="button" class="btn btn-outline-primary col-sm-2 align-self-start">${I18n.t("javascripts.profiles.edit.social_links.remove")}</button>

Key was changed to `profiles.edit.social_links.remove` and `config/i18n-js.yml` was changed accordingly. Approach you suggested is more consistent than what this PR had before. Thanks for the suggestion.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439#discussion_r1962979626
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5439/review/2628905267 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250219/3a3a48da/attachment.htm>


More information about the rails-dev mailing list