[openstreetmap/openstreetmap-website] Displays "unknown" description for notes with missing opening comment (PR #5712)

[Tom Hughes]

@tomhughes commented on this pull request.



> @@ -43,7 +43,7 @@ def show
 
     @note_includes_anonymous = @note.author.nil? || @note_comments.find { |comment| comment.author.nil? }
 
-    @note_comments = @note_comments.drop(1) if @note.author.nil? || @note.author.active?
+    @note_comments = @note_comments.drop(1) if (@note.author.nil? || @note.author.active?) && @note.description.present?

Nothing in the helper is looking at `@note_comments` though? All the tests in there are either on the note (which might defer to `all_comments` for an old note) or on `all_comments` directly.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5712#discussion_r1964415211
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5712/review/2631283427 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250220/7063b2f1/attachment.htm>