[openstreetmap/openstreetmap-website] Add locale selector (PR #5201)

[Tom Hughes]

@tomhughes requested changes on this pull request.



> @@ -52,6 +52,13 @@ time[title] {
   color: $blue;
 }
 
+/* Utility for transparent color */
+
+.text-transparent{

Space before the brace please.

> @@ -0,0 +1,15 @@
+<label class="position-relative d-flex <%= classes %>" role="button">
+  <svg width="20" height="20" fill="currentColor">
+    <path d="M20 18h-1.44a.61.61 0 0 1-.4-.12.81.81 0 0 1-.23-.31L17 15h-5l-1 2.54a.77.77 0 0 1-.22.3.59.59 0 0 1-.4.14H9l4.55-11.47h1.89zm-3.53-4.31L14.89 9.5a11.62 11.62 0 0 1-.39-1.24q-.09.37-.19.69l-.19.56-1.58 4.19zm-6.3-1.58a13.43 13.43 0 0 1-2.91-1.41 11.46 11.46 0 0 0 2.81-5.37H12V4H7.31a4 4 0 0 0-.2-.56C6.87 2.79 6.6 2 6.6 2l-1.47.5s.4.89.6 1.5H0v1.33h2.15A11.23 11.23 0 0 0 5 10.7a17.19 17.19 0 0 1-5 2.1q.56.82.87 1.38a23.28 23.28 0 0 0 5.22-2.51 15.64 15.64 0 0 0 3.56 1.77zM3.63 5.33h4.91a8.11 8.11 0 0 1-2.45 4.45 9.11 9.11 0 0 1-2.46-4.45z" />
+  </svg>
+  <% unless disabled %>
+    <select role="button" class="p-0 position-absolute top-0 start-0 w-100 h-100 language-change-trigger text-transparent bg-transparent <%= classes %>">

I don't really like the whole thing about overlaying an SVG on a transparent select to be honest but I don't have a good alternative either.

> @@ -1984,6 +1984,8 @@ en:
       users:
         older: Older Users
         newer: Newer Users
+    language_selector:
+      language: English

I think this is very problematic... We're going to have translators translating this to the localised version of "English" rather than the name of their own language.

Also until it is translated languages just don't appear, and we start with a menu that only has english on it and hence looks really silly.

Maybe this should have one key for each language (so `languages.en`, `languages.fr` etc) with the english version and then people can translate them all even if many of them won't immediately be used and we can either show both versions with one in parentheses in the menu, or we can show the localised version with fallback to english.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5201#pullrequestreview-2648759418
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5201/review/2648759418 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250227/de2ca239/attachment.htm>