[openstreetmap/openstreetmap-website] Remove "expired unread" short block status (PR #5454)

Anton Khorev notifications at github.com
Fri Jan 3 08:43:03 UTC 2025


@AntonKhorev commented on this pull request.



> @@ -27,14 +27,10 @@ def block_status(block)
 
   def block_short_status(block)
     if block.active?
-      if block.needs_view?
-        if block.ends_at > Time.now.utc
-          t("user_blocks.helper.short.active_unread")
-        else
-          t("user_blocks.helper.short.expired_unread")
-        end
-      else
+      if block.ends_at > Time.now.utc || block.deactivates_at

I was thinking what to output in case we're between `ends_at` and `deactivates_at` because it's allowed by validations. But since it's currently impossible to get such `deactivates_at`, let's remove it.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5454#discussion_r1901572410
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5454/review/2528722931 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250103/516f0e05/attachment.htm>


More information about the rails-dev mailing list