[openstreetmap/openstreetmap-website] Convert Auth.providers into array (PR #5460)
Anton Khorev
notifications at github.com
Fri Jan 3 11:21:34 UTC 2025
There's `Auth` module that lists currently enabled auth providers. It's used in two different places: auth providers template for login/signup pages and account edit page.
What the module actually does is it prepares options for `<select>` on the account edit page. That's why it includes localization strings as keys of a hash. The template on login/signup pages needs different strings and ignores the keys. Why do we need then to include the localization strings in `Auth` at all?
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5460
-- Commit Summary --
* Convert Auth.providers into array
-- File Changes --
M app/views/accounts/edit.html.erb (6)
M app/views/application/_auth_providers.html.erb (4)
M lib/auth.rb (18)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/5460.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5460.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5460
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5460 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250103/9c1c9440/attachment-0001.htm>
More information about the rails-dev
mailing list