[openstreetmap/openstreetmap-website] display warning in new note form after too many anonymous notes (PR #5468)

Anton Khorev notifications at github.com
Sun Jan 5 05:49:50 UTC 2025


@AntonKhorev commented on this pull request.



> @@ -152,6 +152,16 @@ OSM.NewNote = function (map) {
       .on("input", updateControls)
       .focus();
 
+    var anonymousNotesCount = Number(localStorage.getItem("anonymousNotesCount"));
+
+    if (typeof OSM.user === "undefined" && anonymousNotesCount >= 20) {
+      var counterWarning = content.find("#new-note-counter-warning");
+      if (typeof counterWarning.html() !== "undefined") {
+        counterWarning.html(counterWarning.html().replace("(N)", anonymousNotesCount));

That's not how translatable numerals work. The number could also affect other parts of the sentence in various languages ("24 заметки", "25 заметок").

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5468#pullrequestreview-2530829058
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5468/review/2530829058 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250104/0de7c6a6/attachment.htm>


More information about the rails-dev mailing list