[openstreetmap/openstreetmap-website] Pass bbox to changeset page via data attribute (PR #5471)
Anton Khorev
notifications at github.com
Sun Jan 5 15:10:15 UTC 2025
Fixes #4081 on `/changeset/:id` pages.
Previously changeset bbox was loaded using `L.OSM.DataLayer`. That requied additional http request. Also `L.OSM.DataLayer` assumed that all changesets have bounding boxes which is not true.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5471
-- Commit Summary --
* Remove 'center' argument of addChangeset()
* Move changeset data to a helper
* Write details attribute to changeset page
* Use details attribute to render changeset bounding box
-- File Changes --
M app/assets/javascripts/index/changeset.js (17)
M app/assets/javascripts/leaflet.map.js (25)
M app/helpers/changesets_helper.rb (16)
M app/views/changesets/_changeset.html.erb (14)
M app/views/changesets/show.html.erb (4)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/5471.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5471.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5471
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5471 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250105/d9aead74/attachment-0001.htm>
More information about the rails-dev
mailing list