[openstreetmap/openstreetmap-website] Show diary entry after creation (PR #5484)
Anton Khorev
notifications at github.com
Wed Jan 8 19:03:47 UTC 2025
@AntonKhorev commented on this pull request.
> + assert_redirected_to diary_entry_path(user, user.diary_entries.last)
entry = DiaryEntry.last
> separately
Won't that be a fixup commit which we don't like here?
> do you have any preferences for referring to the entry
Maybe if we use `assert_difference "DiaryEntry.count"`, we should also use `DiaryEntry.last` (or change `assert_difference`).
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5484#discussion_r1907670375
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5484/review/2537974575 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250108/057f68e3/attachment.htm>
More information about the rails-dev
mailing list