[openstreetmap/openstreetmap-website] Moves the note's description, author ID, and author IP from the first comment to the note itself (PR #5485)

Anton Khorev notifications at github.com
Thu Jan 9 09:38:16 UTC 2025


> How does this relate to the notes restructuring plan from https://github.com/openstreetmap/openstreetmap-website/issues/3831?

What I was going to say in comments for #5294 is that the plan from #3831 tries to solve [*(a)* by ignoring *(b)*](https://github.com/openstreetmap/openstreetmap-website/issues/5294#issuecomment-2541527509). You can read the original post of #3831 and see that it doesn't mention not actions at all. And those actions, they are stored in the comments table. You'll still have another *leaky abstraction* as that post says. Note comments won't be really comments. You'll close a note without a comment, that will still generate a "comment" entry in `NoteComments`.

> Is this a step on the way to that or is it going in a different direction?

The direction is hopefully the same for things stated explicitly in #3831. It's different for things omitted.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5485#issuecomment-2579591777
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5485/c2579591777 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250109/0a8e0b07/attachment.htm>


More information about the rails-dev mailing list