[openstreetmap/openstreetmap-website] display an encouragement to contribute after many anonymous notes (PR #5468)

Anton Khorev notifications at github.com
Thu Jan 9 13:15:06 UTC 2025


@AntonKhorev commented on this pull request.



> @@ -5,9 +5,17 @@
 <div class="note">
   <p class="alert alert-info"><%= t(".intro") %></p>
   <% if !current_user %>
-    <p class="alert alert-warning"><%= t ".anonymous_warning_html",
-                                         :log_in => link_to(t(".anonymous_warning_log_in"), login_path(:referer => new_note_path)),
-                                         :sign_up => link_to(t(".anonymous_warning_sign_up"), new_user_path) %></p>
+    <p class="alert alert-warning">
+      <%= t ".anonymous_warning_html",
+            :log_in => link_to(t(".anonymous_warning_log_in"), login_path(:referer => new_note_path)),
+            :sign_up => link_to(t(".anonymous_warning_sign_up"), new_user_path) %>
+    <% if @anonymous_notes_count >= 10 %>

You have a `>=` condition here, but the message reads `You have already posted more than %{x_anonymous_notes}`. If I create exactly 10 notes, it will tell me that I "posted more than 10".

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5468#pullrequestreview-2539888876
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5468/review/2539888876 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250109/14cf9cd2/attachment.htm>


More information about the rails-dev mailing list