[openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)
David Tsiklauri
notifications at github.com
Fri Jan 10 13:58:14 UTC 2025
@nertc commented on this pull request.
> - <%= link_to t(".remove as friend"), remove_friend_path(:display_name => @user.display_name), :method => :post %>
+ <%= link_to t(".unfollow"), follow_path(:display_name => @user.display_name), :method => :delete %>
<% else %>
- <%= link_to t(".add as friend"), make_friend_path(:display_name => @user.display_name), :method => :post %>
+ <%= link_to t(".follow"), follow_path(:display_name => @user.display_name), :method => :post %>
My thought was to use `:edit` as the functionality was focused on editing but not showing information about `follows`. But as https://github.com/openstreetmap/openstreetmap-website/pull/5449#issuecomment-2578415862 suggests, if we use `:show` also as edit page where it is possible, I will change it accordingly. I thought your comment meant to use standard `Singular Resource` routes in general, not `:show` in particular.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5261#discussion_r1910412523
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5261/review/2542502127 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250110/37240b89/attachment-0001.htm>
More information about the rails-dev
mailing list