[openstreetmap/openstreetmap-website] blocks with needs_view flag not shown when user does oauth authorisation (for example login into an OSM editor) (Issue #5490)

Anton Khorev notifications at github.com
Sun Jan 12 16:17:11 UTC 2025


> If we stop that then it would not fix anything and would make things worse. User will be never notified about block

If you want to be lazy, just show the 403 response message. It tells about the block. That's what iD does. We can put an url there to to read the block directly. *User will be never notified about block* if the block doesn't have the needs_view flag and you just delete the token.

> there is no reasonable way to detect block

There are ways to detect blocks

a) assuming that nothing is changed on the website - see https://github.com/streetcomplete/StreetComplete/issues/6062#issuecomment-2565450817 - under this assumption whatever you requesting in issues here also hasn't happened and GDPR-related changes haven't happened

b) assuming that changes happen - #5452 + another change that would add some page, let's say `/account/blocks/check` that would tell the user everything they need to know about their current blocked status. Then you'll have the following options:
- proper option: got 403 - check the current block api - if there are current blocks, tell the user that they either need to view that `/account/blocks/check` page to clear the block, or that they need to wait until a certain date
- lazier option: got 403 - tell the user that maybe they're blocked, go check `/account/blocks/check` to find out
- super lazy option: got 403 - show the server response, like you can do now

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5490#issuecomment-2585795424
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/issues/5490/2585795424 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250112/b12046ce/attachment.htm>


More information about the rails-dev mailing list