[openstreetmap/openstreetmap-website] display an encouragement to contribute after many anonymous notes (PR #5468)

etiennejourdier notifications at github.com
Sun Jan 12 21:57:23 UTC 2025


@etiennejourdier commented on this pull request.



> @@ -30,6 +30,7 @@ def confirm
         user.email_valid = true
         flash[:notice] = gravatar_status_message(user) if gravatar_enable(user)
         user.save!
+        cookies.delete :_osm_anonymous_notes_count

I thought it would be more logical to put the deletion of the cookie on signup here, after email validation. But as I don't have a mail server, I wasn't able to test it. Could that be a problem?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5468#pullrequestreview-2545527677
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5468/review/2545527677 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250112/98431a90/attachment.htm>


More information about the rails-dev mailing list