[openstreetmap/openstreetmap-website] blocks with needs_view flag not shown when user does oauth authorisation (for example login into an OSM editor) (Issue #5490)

[Anton Khorev]

@mnalis

> Here is some pseudocode

This is what effectively already happening for 0-hour needs_view blocks, except instead of marking/unmarking every token there's block activation/deactivation. And its happening *for every app* because there's no mechanism to select a particular app. I don't see any app selection in this pseudocode either: `UPDATE tokens SET valid=false WHERE user_id=$user_id`. Moderators don't know which apps are authorized by users, they can't select which apps to block.

> It seems to me they do that because there is no reasonable better solution available currently

I'd argue that there is, see my previous post.

> I'd say that in all those cases displaying the block message again is just fine

That's not what currently happening. If the user have seen the block message, needs_view is cleared. If the block still has its end date in the future, it's still active, but it won't be shown on login. For it to be show, you have to ignore needs_view and just always show active blocks. This is adding more cases when blocks are shown, similar to what this issue proposes.

>> If we add some kind of notifications for blocks, they won't work because the user needs to be logged in to receive notifications.

> I'm not sure about this. Is that something which already exists, or are you talking about potential future additions of functionality to OSM?

It doesn't exist now.

> In any case, if token is invalidated

I see you edited that post to replace *sessions* with *tokens*. I was responding to the *sessions* version.

> I meant additional change. Surely something already happens in the apps when they receive "403 Forbidden",

Something that already happens is that some apps lie to their users that the token is invalid, although they could have checked it. That includes JOSM by the way. 

>> And I haven't even suggested to display the block message in the app.

> I'll note that this particular problem is also completely avoided in my suggestion

It isn't because the problem here is for the apps that *want to display the message inside the app*. Your suggestion is for the apps that *don't want it*.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5490#issuecomment-2587226746
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/issues/5490/2587226746 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250113/73ab3cc7/attachment-0001.htm>