[openstreetmap/openstreetmap-website] Moves the note's description, author ID, and author IP from the first comment to the note itself (PR #5485)

Anton Khorev notifications at github.com
Tue Jan 14 13:00:57 UTC 2025


> I do wonder how it interacts with comments though - do we duplicate those for every version like we do with members of other objects or do we always show all comments whatever the version or maybe track add the current version to the comment when it's created and then show comments up to the note's version when showing an old version of the note?

I wouldn't say "duplicate (comments) for every version like we do with members of other objects" - do we even have comments for versioned objects elsewhere?

The idea is to take the current comments, let's call them *api 0.6 comments*, and split them into actual comments and versions. Versions will contain states (open/closed/hidden) that were previously in api 0.6 comments. After that it should be possible to reassemble actual comments and versions into api 0.6 comments for use in api calls. This reassembling wouldn't require associating comments with versions if I'm correct.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5485#issuecomment-2589853554
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5485/c2589853554 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250114/cf2adda1/attachment-0001.htm>


More information about the rails-dev mailing list