[openstreetmap/openstreetmap-website] Adds description and author_id methods to Note (PR #5494)

[Tom Hughes]

@tomhughes requested changes on this pull request.



> @@ -36,6 +36,26 @@ class NoteComment < ApplicationRecord
   validates :event, :inclusion => %w[opened closed reopened commented hidden]
   validates :body, :length => { :maximum => 2000 }, :characters => true
 
+  # Return the note's description for first special comment (event is "opened")
+  # otherwise return the comment text
+  def tmp_body

What is the point of these two `tmp` methods? They just wind up circling back to the same comment so there's no need for them at this point.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5494#pullrequestreview-2550765938
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5494/review/2550765938 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250114/a59b13fb/attachment.htm>