[openstreetmap/openstreetmap-website] Use class based map tiles dark mode (PR #5505)
Marwin Hochfelsner
notifications at github.com
Thu Jan 16 19:25:34 UTC 2025
@hlfan commented on this pull request.
> @@ -31,6 +31,7 @@
apiKeyId: "THUNDERFOREST_KEY"
canEmbed: true
canDownloadImage: true
+ filterClass: "no-filter"
I appeal that as long as there isn't documentation on which layers should get which treatment in dark mode, explicitly specifying at least in one file that this layer already has had a review of how it should be displayed in dark mode is critical for maintainability and avoiding unnecessary re-reviews.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5505#discussion_r1919086155
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5505/review/2557086484 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250116/9984784d/attachment.htm>
More information about the rails-dev
mailing list