[openstreetmap/openstreetmap-website] Fix left/right sidebar resizing on mobile devices (PR #5521)
Roman Deev
notifications at github.com
Sun Jan 19 11:45:38 UTC 2025
This PR fixes multiple issues about the map resetting its position when opening various menus on mobile devices.
https://github.com/openstreetmap/openstreetmap-website/issues/4755
https://github.com/openstreetmap/openstreetmap-website/issues/991
...
1. Get rid of the hardcoded left sidebar width.
2. On mobile devices, use adjust the height, not the width of the map
### How has this been tested?
<table>
<tr>
<th>
Before
https://github.com/user-attachments/assets/9c283266-b43a-48d2-9f25-ffe73752c837
<tr>
<th>
After
https://github.com/user-attachments/assets/9cf73154-c043-430a-a143-f8d47ad0f080
<th>
After with RTL
https://github.com/user-attachments/assets/ed973523-98d2-46a8-be2b-ca8619e1085f
</tr>
</table>
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5521
-- Commit Summary --
* Fix left/right sidebar resizing on mobile devices
-- File Changes --
M app/assets/javascripts/leaflet.map.js (25)
M app/assets/javascripts/leaflet.sidebar.js (20)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/5521.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5521.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5521
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5521 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250119/8e8487e3/attachment-0001.htm>
More information about the rails-dev
mailing list