[openstreetmap/openstreetmap-website] Adds optional use of notes records (PR #5511)

Nenad Vujicic notifications at github.com
Tue Jan 21 12:31:05 UTC 2025


@nenad-vujicic commented on this pull request.



>    def description
-    comments.first.body
+    if user_ip.nil? && user_id.nil?
+      comments.first.body
+    else
+      RichText.new("text", self[:description])
+    end
   end

Have we reached a decision on this? We planned to copy the body of the first note's comment (i.e. one with event set to "opened") to note's description ([data migration-script](https://github.com/nenad-vujicic/openstreetmap-website/commit/0cc2d59311479c56e009e0e63b4bdb54113aeb61)), but can easily switch to another logic?

Btw, before data-migration PR we planned 2 more steps ([updating creating](https://github.com/nenad-vujicic/openstreetmap-website/commit/8df2f38e21c0703dfb49267d2b6a3f9bc808a63b) and [updating searching](https://github.com/nenad-vujicic/openstreetmap-website/commit/75212422a99134aa0b67fac4f7c1533f9ffba15d)).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5511#discussion_r1923645103
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5511/review/2564486448 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250121/8f60cb8b/attachment.htm>


More information about the rails-dev mailing list