[openstreetmap/openstreetmap-website] Add user profile heatmap visualization for contributions (PR #5402)
Emin Kocan
notifications at github.com
Wed Jan 22 10:35:01 UTC 2025
@kcne commented on this pull request.
> @@ -53,6 +53,23 @@ def show
if @user &&
(@user.visible? || current_user&.administrator?)
@title = @user.display_name
+
+ one_year_ago = 1.year.ago
This wasn’t about freezing; it should run each time the user profile page is accessed. I guess I left it like that by accident. The idea was to fetch the changeset data from one year ago up until the current date. The thought was that starting one year ago would naturally include changesets up to this moment, effectively capturing the data for the past year.
However, I’ve now refactored the code to explicitly set both the starting and ending points. This makes the date range more declarative and ensures better clarity and consistency, while also eliminating potential ambiguities.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5402#discussion_r1925087216
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5402/review/2566821141 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250122/e41048af/attachment.htm>
More information about the rails-dev
mailing list