[openstreetmap/openstreetmap-website] Use dark mode map tiles in embed (PR #5522)
Holger Jeromin
notifications at github.com
Wed Jan 22 18:29:25 UTC 2025
@HolgerJeromin commented on this pull request.
> @@ -15,10 +15,9 @@ window.onload = function () {
var query = (window.location.search || '?').slice(1),
args = {};
- var pairs = query.split('&');
- for (var i = 0; i < pairs.length; i++) {
- var parts = pairs[i].split('=');
- args[parts[0]] = decodeURIComponent(parts[1] || '');
+ for (var pair of query.split('&')) {
+ var [key, val] = pair.split('=');
+ args[key] = decodeURIComponent(val || '');
}
Using a given API https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams would be much easier.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5522#discussion_r1925785198
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5522/review/2567981392 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250122/f88f91d6/attachment.htm>
More information about the rails-dev
mailing list