[openstreetmap/openstreetmap-website] Use dark mode map tiles in embed (PR #5522)

[Marwin Hochfelsner]

@hlfan commented on this pull request.



> @@ -15,10 +15,9 @@ window.onload = function () {
   var query = (window.location.search || '?').slice(1),
       args  = {};
 
-  var pairs = query.split('&');
-  for (var i = 0; i < pairs.length; i++) {
-    var parts = pairs[i].split('=');
-    args[parts[0]] = decodeURIComponent(parts[1] || '');
+  for (var pair of query.split('&')) {
+    var [key, val] = pair.split('=');
+    args[key] = decodeURIComponent(val || '');
   }

> Using a given API https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams would be much easier.

Well, now I'm intrigued by what other APIs have become available since the last logic touch in the code.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5522#discussion_r1925797053
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5522/review/2567999863 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250122/d6fa0ff3/attachment.htm>