[openstreetmap/openstreetmap-website] Message read_mark and mute resources (PR #5536)
Anton Khorev
notifications at github.com
Thu Jan 23 01:23:48 UTC 2025
Converts remaining actions of messages controller that RuboCop doesn't like into resources:
- `read_mark` which can be created and destroyed instead of `mark` action
- `mute` which can be destroyed instead of `unmute` action
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5536
-- Commit Summary --
* Create message read_mark resource
* Remove unused css classes from inbox table
* Create message mute resource
* Remove RuboCop action names exception for messages controller
-- File Changes --
M .rubocop.yml (1)
M app/abilities/ability.rb (2)
A app/controllers/messages/mutes_controller.rb (33)
A app/controllers/messages/read_marks_controller.rb (39)
M app/controllers/messages_controller.rb (43)
M app/views/messages/mailboxes/_message.html.erb (6)
M app/views/messages/show.html.erb (2)
M config/locales/en.yml (15)
M config/routes.rb (9)
A test/controllers/messages/mutes_controller_test.rb (68)
A test/controllers/messages/read_marks_controller_test.rb (126)
M test/controllers/messages_controller_test.rb (82)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/5536.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5536.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5536
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5536 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250122/c1bf10e9/attachment.htm>
More information about the rails-dev
mailing list