[openstreetmap/openstreetmap-website] Add linting for .js.erb files (Issue #5523)
Splines
notifications at github.com
Fri Jan 24 09:55:37 UTC 2025
If you introduce linting here you might also be interested in:
- How we use ESLint on GitHub Actions via [this file](https://github.com/MaMpf-HD/mampf/blob/23aae01471c4361b85e86df06e349cd8acfb735c/.github/workflows/linter.yml#L39-L75) to lint only the changes inside changed `.js` and `.js.erb` files in a PR (see [this custom action](https://github.com/MaMpf-HD/mampf/blob/main/.github/actions/changed_files/action.yml)).
- A currently open [PR](https://github.com/MaMpf-HD/mampf/pull/730) where I try to set up linting of HTML files via [`html-eslint`](https://html-eslint.org/). Note that you can use my eslint-erb-plugin to also lint the HTML part of `.html.erb` files. Additionally, I set up Shopify's [`erb_lint`](https://github.com/Shopify/erb_lint) to also lint the Ruby part of `.html.erb` files.
- I haven't yet found a way to lint the Ruby part of `.js.erb` files. In the best case, it would work just like `erb_lint`.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5523#issuecomment-2612111999
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/issues/5523/2612111999 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250124/713e1c27/attachment.htm>
More information about the rails-dev
mailing list