[openstreetmap/openstreetmap-website] Replace var in javascript with let/const (PR #5558)

[Tom Hughes]

This updates the eslint config to prohibit use of  `var` and to prefer `const` over `let` and then fixes all uses of `var` to respect that.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5558

-- Commit Summary --

  * Update eslint to prefer let/const over var
  * Replace uses of var with let or const as appropriate

-- File Changes --

    M app/assets/javascripts/application.js (33)
    M app/assets/javascripts/auth_providers.js (2)
    M app/assets/javascripts/diary_entry.js (8)
    M app/assets/javascripts/fixthemap.js (4)
    M app/assets/javascripts/id.js (22)
    M app/assets/javascripts/index.js (60)
    M app/assets/javascripts/index/changeset.js (12)
    M app/assets/javascripts/index/contextmenu.js (42)
    M app/assets/javascripts/index/directions-endpoint.js (12)
    M app/assets/javascripts/index/directions.js (96)
    M app/assets/javascripts/index/directions/fossgis_osrm.js (40)
    M app/assets/javascripts/index/directions/fossgis_valhalla.js (16)
    M app/assets/javascripts/index/directions/graphhopper.js (26)
    M app/assets/javascripts/index/export.js (8)
    M app/assets/javascripts/index/history.js (42)
    M app/assets/javascripts/index/layers/data.js (16)
    M app/assets/javascripts/index/layers/notes.js (22)
    M app/assets/javascripts/index/new_note.js (20)
    M app/assets/javascripts/index/note.js (26)
    M app/assets/javascripts/index/query.js (111)
    M app/assets/javascripts/index/search.js (56)
    M app/assets/javascripts/leaflet.key.js (12)
    M app/assets/javascripts/leaflet.layers.js (34)
    M app/assets/javascripts/leaflet.locate.js (4)
    M app/assets/javascripts/leaflet.map.js (89)
    M app/assets/javascripts/leaflet.note.js (10)
    M app/assets/javascripts/leaflet.query.js (10)
    M app/assets/javascripts/leaflet.share.js (60)
    M app/assets/javascripts/leaflet.sidebar-pane.js (8)
    M app/assets/javascripts/leaflet.sidebar.js (8)
    M app/assets/javascripts/leaflet.zoom.js (12)
    M app/assets/javascripts/matomo.js (6)
    M app/assets/javascripts/oauth.js (2)
    M app/assets/javascripts/richtext.js (24)
    M app/assets/javascripts/router.js (44)
    M app/assets/javascripts/user.js (46)
    M app/assets/javascripts/welcome.js (6)
    M config/eslint.js (2)
    M test/javascripts/osm_test.js (44)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5558.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5558.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5558
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5558 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250126/c71433c4/attachment.htm>