[openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)

David Tsiklauri notifications at github.com
Mon Jan 27 06:31:03 UTC 2025


The reason I used word `followings` instead of `following` in the code is to avoid ambiguities, as `following` can mean 10 different things and it heavily depends on context, while `followings` is certainly a plural form of noun. When model has property `following` it is not obvious if this property is for the array of those people who follow this user, for the array of those people who are followed by this user, is some single object containing some kind of statistical data about those people who follow this user or etc. Adding `-s` makes meaning of the property clearer (property contains array of users who are following this user). To keep everything consistent and to avoid same ambiguity (as we have several pages which use this word) I chose to use `followings` instead of `following`. If, in practice, adding `-s` causes more problems than it solves, it can be changed. But, I think, if we change it, it should be changed only in i18n files, not in the model or other parts of the code.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5261#issuecomment-2614942152
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5261/c2614942152 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250126/de331e07/attachment.htm>


More information about the rails-dev mailing list