[openstreetmap/openstreetmap-website] Show "reporting user" on "issues" screen (PR #4990)

Anton Khorev notifications at github.com
Mon Jan 27 11:24:11 UTC 2025


@AntonKhorev commented on this pull request.



> +    1.upto(5).each do |n|
+      issue.reports << create(:report, :user => create(:user, :display_name => "Test Name #{n}"))
+    end

```suggestion
create_list(:report, 5, :issue => issue)
```
because you're not checking if usernames match `"Test Name #{n}"`.

And probably the same in the next test.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4990#pullrequestreview-2575172169
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4990/review/2575172169 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250127/6d9154a1/attachment.htm>


More information about the rails-dev mailing list