[openstreetmap/openstreetmap-website] Adds optional use of notes records (PR #5511)

Anton Khorev notifications at github.com
Tue Jan 28 08:58:10 UTC 2025


@AntonKhorev commented on this pull request.



> -  def test_description
-    comment = create(:note_comment)
-    assert_equal comment.body, comment.note.description
-
-    user = create(:user)
-    comment = create(:note_comment, :author => user)
-    assert_equal comment.body, comment.note.description
-  end

You dropped `note.description` a few commits before. Why did you keep the tests until this commit?

+ same for `note.author_id` and `author_ip`

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5511#pullrequestreview-2577511169
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5511/review/2577511169 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250128/fa46eefd/attachment.htm>


More information about the rails-dev mailing list