[openstreetmap/openstreetmap-website] Adds optional use of notes records (PR #5511)

[Anton Khorev]

@AntonKhorev commented on this pull request.



> @@ -7,6 +7,7 @@ end
 
 json.properties do
   json.id note.id
+  json.description note_description(note)

Let's suppose you have a normal note. No deleted users touched it. From the API point of view its description is in the first comment. If you add a description like here, you'll have it twice in the API output. You can't remove it from the first comment because it's not backwards compatible. Does it make sense to have it twice? And that's not the only way to fix the tooltip problem. You could instead add some attribute to an API comment that indicates if it's a description or not. In other words, you shouldn't do this here because it's a completely different problem.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5511#discussion_r1931817739
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5511/review/2577604784 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250128/7bfe99e3/attachment-0001.htm>