[openstreetmap/openstreetmap-website] Show "reporting user" on "issues" screen (PR #4990)

David Tsiklauri notifications at github.com
Wed Jan 29 08:58:46 UTC 2025


@nertc commented on this pull request.



> @@ -44,6 +44,15 @@ def index
     end
 
     @issues, @newer_issues_id, @older_issues_id = get_page_items(@issues, :limit => @params[:limit])
+
+    @unique_reporters = @issues.each_with_object({}) do |issue, reporters|
+      user_ids = issue.reports.order(:created_at => :desc).map(&:user_id).uniq
+      reporters[issue.id] = {
+        :count => user_ids.size,
+        :users => User.where(:id => user_ids.first(3)).index_by(&:id).values_at(*user_ids.first(3))

Thanks for the suggestion. PR was updated. User selection was changed with much smaller and cleaner code you suggested.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4990#discussion_r1933491750
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4990/review/2580380553 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250129/03d501c2/attachment.htm>


More information about the rails-dev mailing list