[openstreetmap/openstreetmap-website] Add social profile links (PR #5439)
Anton Khorev
notifications at github.com
Fri Jan 31 10:56:34 UTC 2025
@AntonKhorev commented on this pull request.
> @@ -231,10 +231,15 @@
</div>
<% end %>
-<div class="richtext text-break clearfix"><%= @user.description.to_html %></div>
-
-<% if current_user and @user.id == current_user.id %>
- <div class="my-3">
- <%= link_to t(".edit_profile"), edit_profile_path, :class => "btn btn-outline-primary" %>
+<div class="row">
+ <div class="col-sm-3">
+ <%= render "social_links/show",
+ :social_links => @user.social_links %>
+ <% if current_user and @user.id == current_user.id %>
+ <div class="my-3">
+ <%= link_to t(".edit_profile"), edit_profile_path, :class => "btn btn-outline-primary" %>
+ </div>
+ <% end %>
The placement of this button suggests that it leads to editing only the social links. If it actually did, that could have been a good idea, given how many editable things there are already on `profile/edit`.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439#pullrequestreview-2586282184
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5439/review/2586282184 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250131/2b3bdaf0/attachment.htm>
More information about the rails-dev
mailing list