[openstreetmap/openstreetmap-website] Adds optional use of note's author and description v2 (PR #5579)

[Anton Khorev]

@AntonKhorev commented on this pull request.



>    def description
-    comments.first.body
+    if user_ip.nil? && user_id.nil?
+      comments.first.body
+    else
+      RichText.new("text", super)
+    end
   end

How is this PR going to go in a different direction?

You're again first revealing the description (if the migration is completed) then maybe later you'll hide it with a helper. That brings you back to https://github.com/openstreetmap/openstreetmap-website/pull/5511#discussion_r1921570888. Why wouldn't you start with a helper?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5579#pullrequestreview-2586111577
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5579/review/2586111577 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250131/2ef0df2d/attachment.htm>