[openstreetmap/openstreetmap-website] Integrate human-readable wikidata browser plugin (PR #6127)
Anton Khorev
notifications at github.com
Wed Jul 2 16:26:44 UTC 2025
@AntonKhorev commented on this pull request.
> @@ -17,10 +17,16 @@ def format_value(key, value)
elsif wdt = wikidata_links(key, value)
# IMPORTANT: Note that wikidata_links() returns an array of hashes, unlike for example wikipedia_link(),
# which just returns one such hash.
+ svg = tag.a :href => "", :class => "float-end m-1 d-flex wdt-preview", :data => { :qids => wdt.map { |w| w[:title] } } do
For example, a screen reader is going to announce `<a>` as "Wikidata item preview visited link", which it isn't and if you visit it as a link, you're not getting wikidata item preview. `<button>` is announced as "Wikidata item preview push button".
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127#discussion_r2180492032
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6127/review/2979846228 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250702/7e668597/attachment-0001.htm>
More information about the rails-dev
mailing list