[openstreetmap/openstreetmap-website] Integrate human-readable wikidata browser plugin (PR #6127)
Minh Nguyễn
notifications at github.com
Thu Jul 3 18:58:27 UTC 2025
@1ec5 commented on this pull request.
> + icon: ["P8972", "P154", "P14"].reduce((out, prop) => out ?? entity.claims[prop]?.[0]?.mainsnak?.datavalue?.value, null),
+ description: localizedProperty("descriptions", langs)?.value,
+ article: localizedProperty("sitelinks", wikis)
+ };
+ return data;
+ }
+
+ function renderWikidataResponse(data, $btn) {
+ const cell = $("<td>")
+ .attr("colspan", 2)
+ .addClass("bg-body-tertiary");
+
+ if (data.icon && OSM.WIKIMEDIA_COMMONS_URL) {
+ $("<a>")
+ .attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" + data.icon)
+ .append($("<img>").attr({ src: OSM.WIKIMEDIA_COMMONS_URL + "Special:FilePath/" + data.icon, height: "32" }))
> Did Wikimedia ever reacted to how we use their images in iD, or was it just in wiki? Or are they already rate-limiting us in iD too but it's not very noticeabe because images are small?
Only on the wiki, because the requests to Wikimedia Commons are centralized through the wiki’s server. This client-side usage is different in that each individual user will request only the images they’re interested in.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127#discussion_r2183556357
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6127/review/2984352978 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250703/c9a2fbd3/attachment.htm>
More information about the rails-dev
mailing list