[openstreetmap/openstreetmap-website] Integrate human-readable wikidata browser plugin (PR #6127)
Marwin Hochfelsner
notifications at github.com
Sat Jul 5 00:58:42 UTC 2025
@hlfan commented on this pull request.
> + $("<a>")
+ .attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" + data.icon)
+ .append($("<img>").attr({ src: OSM.WIKIMEDIA_COMMONS_URL + "Special:FilePath/" + data.icon, height: "32" }))
+ .addClass("float-end mb-1 ms-2")
+ .appendTo(cell);
+ }
+ if (data.label) {
+ $btn
+ .siblings(`a[href*="wikidata.org/entity/${data.qid}"]`)
+ .clone()
+ .text(data.label)
+ .addClass("me-1")
+ .appendTo(cell);
+ }
+ if (data.article) {
+ $(`<${data.label ? "sup" : "div"}>`)
I've added `lang=` and `dir=auto` for language fallbacks. I put `dir=auto` instead of `<bdi>` to avoid additional nesting, even though I haven't seen the bda fail on this yet.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127#discussion_r2186283797
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6127/review/2988621058 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250704/8a745df8/attachment.htm>
More information about the rails-dev
mailing list