[openstreetmap/openstreetmap-website] Move integration tests out of api relation controller tests (PR #6171)
Anton Khorev
notifications at github.com
Mon Jul 7 04:52:51 UTC 2025
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6171
-- Commit Summary --
* Assert that hashes are equal without iterating over items
* Remove sorting before converting tags to hash
* Shorten tags to hash conversion
* Assert that relation member arrays are equal without iterating
* Remove with_relation private method
* Remove with_update_* block/yield
* Change method to compare tags with response
* Inline single-use with_update_* methods
* Remove unnecessary with_controller around check_ordering
* Convert check ordering method into assert on response
* Move relation-changeset integration tests out of controller tests
* Add extra members test for history table
* Move tests comparing relation members with response to integration tests
* Move tests comparing relation tags with response to integration tests
-- File Changes --
M test/controllers/api/relations_controller_test.rb (508)
M test/integration/changeset_bbox_test.rb (194)
A test/integration/relation_versions_test.rb (293)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/6171.patch
https://github.com/openstreetmap/openstreetmap-website/pull/6171.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6171
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6171 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250706/434ecbd9/attachment-0001.htm>
More information about the rails-dev
mailing list