[openstreetmap/openstreetmap-website] Integrate human-readable wikidata browser plugin (PR #6127)

Anton Khorev notifications at github.com
Tue Jul 15 17:50:02 UTC 2025


@AntonKhorev commented on this pull request.



> +    if (data.icon && OSM.WIKIMEDIA_COMMONS_URL) {
+      let src = OSM.WIKIMEDIA_COMMONS_URL + "Special:Redirect/file/" + encodeURIComponent(data.icon);
+      if (!data.icon.endsWith(".svg")) src += "?width=128";
+      $("<a>")
+        .attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" + encodeURIComponent(data.icon))
+        .append($("<img>").attr({ src, height: "32" }))
+        .addClass("float-end mb-1 ms-2")
+        .appendTo(cell);
+    }
+    if (data.label) {
+      const label = $btn
+        .siblings(`a[href*="wikidata.org/entity/${data.qid}"]`)
+        .clone()
+        .text(data.label.value)
+        .attr("dir", "auto");
+      cell.append($("<span>").append(label));

What is this `<span>` for?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127#pullrequestreview-3021576291
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6127/review/3021576291 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250715/3fd46990/attachment-0001.htm>


More information about the rails-dev mailing list