[openstreetmap/openstreetmap-website] Update "Latest diaries" icons (PR #6216)
Marwin Hochfelsner
notifications at github.com
Tue Jul 22 12:02:39 UTC 2025
@hlfan commented on this pull request.
> @@ -0,0 +1,3 @@
+<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" fill="currentColor" viewBox="0 0 16 16">
I see you also removed the "bi" classes that Bootstrap uses to set the icon size to the font size that would set the size for you.
`xmlns` isn't needed when part of an HTML file, but for standalone files, as they are stored, ["an SVG namespace declaration must be provided so that all SVG elements are identified as belonging to the SVG namespace."](https://www.w3.org/TR/SVG/struct.html#Namespace)
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6216#discussion_r2222303209
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6216/review/3042666512 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250722/0399232a/attachment.htm>
More information about the rails-dev
mailing list