[openstreetmap/openstreetmap-website] Image download with user feedback (PR #6192)
Marwin Hochfelsner
notifications at github.com
Thu Jul 24 16:37:00 UTC 2025
@hlfan commented on this pull request.
> + $("#export-image").on("turbo:submit-end", async function (event) {
+ if (event.detail.success) {
+ await handleExportSuccess(event.detail.fetchResponse);
+ } else {
+ await handleExportError(event);
+ }
+ });
I don't think you'd need to `await` in here, then the function can also be synchronous.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192#pullrequestreview-3052400905
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6192/review/3052400905 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250724/42efa0f3/attachment-0001.htm>
More information about the rails-dev
mailing list