[openstreetmap/openstreetmap-website] Image download with user feedback (PR #6192)

Marwin Hochfelsner notifications at github.com
Thu Jul 24 19:58:57 UTC 2025


@hlfan commented on this pull request.



> +    $("#export-image").on("turbo:submit-end", async function (event) {
+      if (event.detail.success) {
+        await handleExportSuccess(event.detail.fetchResponse);
+      } else {
+        await handleExportError(event);
+      }
+    });

jquery-simulate is used for forwarding changeset bbox clicks to the corresponding link, so modifier keys work as expected.
Not sure why it should interfere here.

If I understand correctly the awaits here are more for de-promise-ifying the already resolved promises than actual awaiting at the time of the submit-end event, so I'm not expecting a generally noticeable timing difference. 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192#discussion_r2229456630
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6192/review/3053094754 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250724/87236515/attachment.htm>


More information about the rails-dev mailing list