[openstreetmap/openstreetmap-website] Image download with user feedback (PR #6192)

Tom Hughes notifications at github.com
Fri Jul 25 10:58:55 UTC 2025


@tomhughes commented on this pull request.



> +    $("#export-image").on("turbo:submit-end", async function (event) {
+      if (event.detail.success) {
+        await handleExportSuccess(event.detail.fetchResponse);
+      } else {
+        await handleExportError(event);
+      }
+    });

We already use the native `click` method in a number of places - the only place that uses simulate is the history code.

Note that `click` originally only worked on buttons and input fields and not links (which is what the history code uses) but that changed in Chome 19 / Firefox 5! 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192#discussion_r2230801035
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6192/review/3054987522 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250725/2cd908c5/attachment.htm>


More information about the rails-dev mailing list