[openstreetmap/openstreetmap-website] Map XML download with Turbo (PR #6255)
mmd
notifications at github.com
Sat Jul 26 11:40:17 UTC 2025
Map XML download currently has a few issues, such as a button staying in disabled state after a download, or error messages that are shown on a blank page.
Applying the same concepts as in #6192, this PR aims at making the download a bit more robust and user friendly.
We have a bit of code duplication here, and it would probably make sense to move downloadBlob, handleExportError and turbo:submit-end handler to a common file. Any ideas?
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6255
-- Commit Summary --
* Fix map xml download
-- File Changes --
M app/assets/javascripts/index/export.js (50)
M app/views/site/export.html.erb (4)
M config/locales/en.yml (1)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/6255.patch
https://github.com/openstreetmap/openstreetmap-website/pull/6255.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6255
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6255 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250726/c1e3c117/attachment.htm>
More information about the rails-dev
mailing list