[openstreetmap/openstreetmap-website] Replace javascript alerts with bootstrap modals (PR #6268)

Tom Hughes notifications at github.com
Wed Jul 30 18:26:19 UTC 2025


This builds on the work from #6263 by replacing all other uses of `alert` with bootstrap modals.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/6268

-- Commit Summary --

  * Move showAlert function out of download utilities
  * Move export failed message to the title of the alert
  * Use modal alert when remote editing fails
  * Use modal alert to report an unconfigured iD
  * Use modal alert for geocoding failures

-- File Changes --

    M app/assets/javascripts/download_util.js (11)
    M app/assets/javascripts/edit/id.js.erb (4)
    M app/assets/javascripts/index.js (4)
    M app/assets/javascripts/index/directions-endpoint.js (4)
    M app/assets/javascripts/osm.js.erb (9)
    M app/views/layouts/_header.html.erb (2)
    M config/i18n.yml (2)
    M config/locales/en.yml (18)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/6268.patch
https://github.com/openstreetmap/openstreetmap-website/pull/6268.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6268
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6268 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250730/78d1ee08/attachment-0001.htm>


More information about the rails-dev mailing list