From notifications at github.com Sun Jun 1 00:05:49 2025 From: notifications at github.com (Marwin Hochfelsner) Date: Sat, 31 May 2025 17:05:49 -0700 Subject: [openstreetmap/openstreetmap-website] Use only differences to OSM logo in internal social link icons (PR #6072) Message-ID: Following the discussion in #6065, this PR drops the OSM logo parts of social link icons for OSM related projects to make the icons more easily distinguishable. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6072 -- Commit Summary -- * Use only differences to OSM logo in internal social link icons * Use bs light mode bg secondary color consistently in social link icons -- File Changes -- M app/assets/images/social_link_icons/ogf.svg (16) M app/assets/images/social_link_icons/ohm.svg (280) M app/assets/images/social_link_icons/osm_forum.svg (3375) M app/assets/images/social_link_icons/osm_wiki.svg (337) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/6072.patch https://github.com/openstreetmap/openstreetmap-website/pull/6072.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6072 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/openstreetmap-website/pull/6072 at github.com> -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 00:06:30 2025 From: notifications at github.com (github-actions[bot]) Date: Sat, 31 May 2025 17:06:30 -0700 Subject: [openstreetmap/openstreetmap-website] Use only differences to OSM logo in internal social link icons (PR #6072) In-Reply-To: References: Message-ID: github-actions[bot] left a comment (openstreetmap/openstreetmap-website#6072)
1 Warning
:warning: Number of updated lines of code is too large to be in one PR. Perhaps it should be separated into two or more?

Generated by :no_entry_sign: Danger

-- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6072#issuecomment-2926049774 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 13:39:08 2025 From: notifications at github.com (Anton Khorev) Date: Sun, 01 Jun 2025 06:39:08 -0700 Subject: [openstreetmap/openstreetmap-website] Use only differences to OSM logo in internal social link icons (PR #6072) In-Reply-To: References: Message-ID: AntonKhorev left a comment (openstreetmap/openstreetmap-website#6072) Let's start with a change that shouldn't be in this PR. "Use bs light mode bg secondary color consistently". Are you taking line width into account? (no) -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6072#issuecomment-2927246159 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 13:44:19 2025 From: notifications at github.com (Mahmoud Hanafy) Date: Sun, 01 Jun 2025 06:44:19 -0700 Subject: [openstreetmap/openstreetmap-website] Slow response in rendering phase while calling /map endpoint (Issue #6057) In-Reply-To: References: Message-ID: mahmoudhanafy left a comment (openstreetmap/openstreetmap-website#6057) Thanks for your response @HolgerJeromin I didn't know about cgimap before, I'm using it now and it's working much faster. I'm going to close this issue, as it should be fixed by the PR I merged. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6057#issuecomment-2927250351 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 13:44:18 2025 From: notifications at github.com (Mahmoud Hanafy) Date: Sun, 01 Jun 2025 06:44:18 -0700 Subject: [openstreetmap/openstreetmap-website] Slow response in rendering phase while calling /map endpoint (Issue #6057) In-Reply-To: References: Message-ID: Closed #6057 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6057#event-17914289685 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 14:00:54 2025 From: notifications at github.com (Mahmoud Hanafy) Date: Sun, 01 Jun 2025 07:00:54 -0700 Subject: [openstreetmap/openstreetmap-website] JOSM can't use OAuth2 to connect to my local osm-website (Issue #6073) Message-ID: mahmoudhanafy created an issue (openstreetmap/openstreetmap-website#6073) Hi Team, I'm trying to connect from JOSM to osm using OAuth2 but I see this the following in the logs: ``` 2025-06-01 14:35:14.134 SEVERE: Authentication failed - Authentication at the OSM server with the username 'my_user' failed.
Please check the username and the password in the JOSM preferences. 2025-06-01 14:37:05.429 INFO: GET https://osm.test/.well-known/oauth-authorization-server -> HTTP/1.1 404 (464 ms; 4.86 kB) 2025-06-01 14:37:05.735 INFO: GET https://osm.test/.well-known/oauth-authorization-server -> HTTP/1.1 404 (148 ms; 4.86 kB) 2025-06-01 14:37:06.027 INFO: GET https://osm.test/.well-known/oauth-authorization-server -> HTTP/1.1 404 (149 ms; 4.86 kB) ``` I'm pretty sure the username and password I'm using are correct (I use them to login on the website0. I was first using older version of the code and it was working fine with basic authentication. but after upgrading to the latest version of the code I got the following errors, and I can't authenticate with basic authentication or OAuth2 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6073 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 14:19:00 2025 From: notifications at github.com (Tom Hughes) Date: Sun, 01 Jun 2025 07:19:00 -0700 Subject: [openstreetmap/openstreetmap-website] Use map control labels in system tests (PR #6070) In-Reply-To: References: Message-ID: tomhughes left a comment (openstreetmap/openstreetmap-website#6070) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6070#issuecomment-2927297151 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 14:22:48 2025 From: notifications at github.com (Tom Hughes) Date: Sun, 01 Jun 2025 07:22:48 -0700 Subject: [openstreetmap/openstreetmap-website] Use map control labels in system tests (PR #6070) In-Reply-To: References: Message-ID: Merged #6070 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6070#event-17914637462 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 14:22:46 2025 From: notifications at github.com (Tom Hughes) Date: Sun, 01 Jun 2025 07:22:46 -0700 Subject: [openstreetmap/openstreetmap-website] Bump eslint from 9.27.0 to 9.28.0 (PR #6068) In-Reply-To: References: Message-ID: Merged #6068 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6068#event-17914637473 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 15:07:08 2025 From: notifications at github.com (Tom Hughes) Date: Sun, 01 Jun 2025 08:07:08 -0700 Subject: [openstreetmap/openstreetmap-website] JOSM can't use OAuth2 to connect to my local osm-website (Issue #6073) In-Reply-To: References: Message-ID: tomhughes left a comment (openstreetmap/openstreetmap-website#6073) Username and password have nothing to do with OAuth2 though? If you were using OAuth2 you wouldn't give those to JOSM but instead you would be directed to the web site to login and get a token for JOSM. You will to register an OAuth2 client in your local copy of the web site and then give JOSM the client ID and key - how you do that is something you will need to ask the JOSM developers about if you don't already know. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6073#issuecomment-2927388678 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 15:07:08 2025 From: notifications at github.com (Tom Hughes) Date: Sun, 01 Jun 2025 08:07:08 -0700 Subject: [openstreetmap/openstreetmap-website] JOSM can't use OAuth2 to connect to my local osm-website (Issue #6073) In-Reply-To: References: Message-ID: Closed #6073 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6073#event-17915111619 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 15:16:47 2025 From: notifications at github.com (Tom Hughes) Date: Sun, 01 Jun 2025 08:16:47 -0700 Subject: [openstreetmap/openstreetmap-website] Advanced preferences, language dropdown in basic preferences (PR #6024) In-Reply-To: References: Message-ID: @tomhughes approved this pull request. I guess a static file works as well at least for now, so I think this is good to merge, thaks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6024#pullrequestreview-2885744240 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 15:18:48 2025 From: notifications at github.com (Tom Hughes) Date: Sun, 01 Jun 2025 08:18:48 -0700 Subject: [openstreetmap/openstreetmap-website] Advanced preferences, language dropdown in basic preferences (PR #6024) In-Reply-To: References: Message-ID: Merged #6024 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6024#event-17915210508 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 15:18:50 2025 From: notifications at github.com (Tom Hughes) Date: Sun, 01 Jun 2025 08:18:50 -0700 Subject: [openstreetmap/openstreetmap-website] Add language dropdown menu (#2581) In-Reply-To: References: Message-ID: Closed #2581 as completed via #6024. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2581#event-17915210565 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 16:18:24 2025 From: notifications at github.com (Anton Khorev) Date: Sun, 01 Jun 2025 09:18:24 -0700 Subject: [openstreetmap/openstreetmap-website] Redraw OpenGeofiction social icon (PR #6074) Message-ID: #6072 tried to change the color of the ogf icon to match the colors of other social icons. Except that wouldn't work as intended because the lines in the ogf icon are narrower than 1px. It already looks bleak, and with that color change it's going to be bleaker. There's not much to be done about it other than redrawing the entire icon. That's what this PR does. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6074 -- Commit Summary -- * Redraw OpenGeofiction social icon -- File Changes -- M app/assets/images/social_link_icons/ogf.svg (19) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/6074.patch https://github.com/openstreetmap/openstreetmap-website/pull/6074.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6074 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/openstreetmap-website/pull/6074 at github.com> -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 16:27:55 2025 From: notifications at github.com (Anton Khorev) Date: Sun, 01 Jun 2025 09:27:55 -0700 Subject: [openstreetmap/openstreetmap-website] Fix sorting of enclosing features with bounds including antimeridian (PR #6069) In-Reply-To: References: Message-ID: @AntonKhorev pushed 3 commits. acfadceb6d0686e809f914485a3cfa450fc56542 Fix overpass query feature areas for bounds including antimeridian 0495960282330c697609494c19c7fd2a34f498f6 Remove unnecessary consts in overpass query js controller 740b5720317208fd72e9f450bedda1ffebf993a2 Test overpass query enclosing features sorting -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6069/files/b6e44b4928ac5a2c913407c7e2af3c6524d2e37a..740b5720317208fd72e9f450bedda1ffebf993a2 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 16:37:47 2025 From: notifications at github.com (Marwin Hochfelsner) Date: Sun, 01 Jun 2025 09:37:47 -0700 Subject: [openstreetmap/openstreetmap-website] Use only differences to OSM logo in internal social link icons (PR #6072) In-Reply-To: References: Message-ID: @hlfan pushed 0 commits. -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6072/files/2fab010e80017837e110a9bf147a3ad6c67eb2ed..ba8b9ed6d358880f38540cb8b6c2eb7c1ea54b51 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 16:38:15 2025 From: notifications at github.com (Mahmoud Hanafy) Date: Sun, 01 Jun 2025 09:38:15 -0700 Subject: [openstreetmap/openstreetmap-website] JOSM can't use OAuth2 to connect to my local osm-website (Issue #6073) In-Reply-To: References: Message-ID: mahmoudhanafy left a comment (openstreetmap/openstreetmap-website#6073) Hi Tom, Thanks for your response. The problem I currently have is that the authorisation button is disabled. and I see the following message in JOSM logs ``` 2025-06-01 14:37:05.429 INFO: GET https://osm.test/.well-known/oauth-authorization-server -> HTTP/1.1 404 (464 ms; 4.86 kB) ``` and I see these message on osm-website logs: ``` [09203e1b354075ed30b649b51ae6100a] ActionController::RoutingError (No route matches [GET] "/.well-known/oauth-authorization-server"): [09203e1b354075ed30b649b51ae6100a] [09203e1b354075ed30b649b51ae6100a] Processing by ErrorsController#not_found as */* [09203e1b354075ed30b649b51ae6100a] Rendering layout layouts/error.html.erb [09203e1b354075ed30b649b51ae6100a] Rendering errors/not_found.html.erb within layouts/error [09203e1b354075ed30b649b51ae6100a] Rendered errors/_contact.html.erb (Duration: 0.2ms | GC: 0.0ms) [09203e1b354075ed30b649b51ae6100a] Rendered errors/not_found.html.erb within layouts/error (Duration: 0.5ms | GC: 0.0ms) [09203e1b354075ed30b649b51ae6100a] Rendered layouts/_meta.html.erb (Duration: 1.2ms | GC: 0.0ms) [09203e1b354075ed30b649b51ae6100a] Rendered layout layouts/error.html.erb (Duration: 2.2ms | GC: 0.0ms) [09203e1b354075ed30b649b51ae6100a] Completed 404 Not Found in 3ms (Views: 2.6ms | ActiveRecord: 0.0ms (0 queries, 0 cached) | GC: 0.0ms) ``` I think something is misconfigured at the website, not sure exactly. Image Image -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6073#issuecomment-2927505357 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 16:38:42 2025 From: notifications at github.com (Marwin Hochfelsner) Date: Sun, 01 Jun 2025 09:38:42 -0700 Subject: [openstreetmap/openstreetmap-website] Use only differences to OSM logo in internal social link icons (PR #6072) In-Reply-To: References: Message-ID: hlfan left a comment (openstreetmap/openstreetmap-website#6072) >Let's start with a change that shouldn't be in this PR Removed since taken care of in #6074 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6072#issuecomment-2927505772 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 17:00:18 2025 From: notifications at github.com (Marwin Hochfelsner) Date: Sun, 01 Jun 2025 10:00:18 -0700 Subject: [openstreetmap/openstreetmap-website] Move html from javascript to views (PR #6063) In-Reply-To: References: Message-ID: @hlfan pushed 7 commits. 73f51a8dacdc896d1c9a24a5804217935b01e4d0 Write layer sidebar in erb template 912d58d71d14e7eb9069986e0406f9d932c0e4f7 Write share sidebar in erb template 437ba4650c07801c79b0670c844a86ab880778a6 Move layer sidebar translations fe9c6c02dc35c28e0897265ce6ad8c25f0775b85 Move share sidebar translations 3ce8868ce1b1c807432902bffb380b1915648934 Put key content class in erb and load content only once 258d2115622207c3e01e2798b11aaa26899b189e Add loadContent function to sidebarPane df161885e6f2cdec5f1ae6520aa831bea8d4c169 Make event handler logic more terse -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6063/files/405a7d1931c6ae445258b91d67461e65bc87ccda..df161885e6f2cdec5f1ae6520aa831bea8d4c169 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 17:13:57 2025 From: notifications at github.com (mmd) Date: Sun, 01 Jun 2025 10:13:57 -0700 Subject: [openstreetmap/openstreetmap-website] JOSM can't use OAuth2 to connect to my local osm-website (Issue #6073) In-Reply-To: References: Message-ID: mmd-osm left a comment (openstreetmap/openstreetmap-website#6073) Did you configure doorkeeper_signing_key in your settings.local.yml? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6073#issuecomment-2927568676 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 17:39:05 2025 From: notifications at github.com (Tom Hughes) Date: Sun, 01 Jun 2025 10:39:05 -0700 Subject: [openstreetmap/openstreetmap-website] Redraw OpenGeofiction social icon (PR #6074) In-Reply-To: References: Message-ID: tomhughes left a comment (openstreetmap/openstreetmap-website#6074) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6074#issuecomment-2927599057 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 17:44:11 2025 From: notifications at github.com (Tom Hughes) Date: Sun, 01 Jun 2025 10:44:11 -0700 Subject: [openstreetmap/openstreetmap-website] Fix sorting of enclosing features with bounds including antimeridian (PR #6069) In-Reply-To: References: Message-ID: Merged #6069 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6069#event-17916412499 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 17:44:10 2025 From: notifications at github.com (Tom Hughes) Date: Sun, 01 Jun 2025 10:44:10 -0700 Subject: [openstreetmap/openstreetmap-website] Redraw OpenGeofiction social icon (PR #6074) In-Reply-To: References: Message-ID: Merged #6074 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6074#event-17916412498 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 17:43:54 2025 From: notifications at github.com (Tom Hughes) Date: Sun, 01 Jun 2025 10:43:54 -0700 Subject: [openstreetmap/openstreetmap-website] Fix sorting of enclosing features with bounds including antimeridian (PR #6069) In-Reply-To: References: Message-ID: tomhughes left a comment (openstreetmap/openstreetmap-website#6069) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6069#issuecomment-2927608607 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 17:47:31 2025 From: notifications at github.com (Tom Hughes) Date: Sun, 01 Jun 2025 10:47:31 -0700 Subject: [openstreetmap/openstreetmap-website] Add dir=auto to user generated content (PR #3429) In-Reply-To: References: Message-ID: @tomhughes pushed 2 commits. bc513474d85733de14f909e9468ffbf9ad635bc4 Add dir=auto to user generated content 6e904d18a1ee8638d0951c9e4d3187eb980ad407 Add dir=auto to usernames -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/3429/files/deb0ed84c4fe5435d72043a18757ed599034831b..6e904d18a1ee8638d0951c9e4d3187eb980ad407 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 17:48:10 2025 From: notifications at github.com (Tom Hughes) Date: Sun, 01 Jun 2025 10:48:10 -0700 Subject: [openstreetmap/openstreetmap-website] JOSM can't use OAuth2 to connect to my local osm-website (Issue #6073) In-Reply-To: References: Message-ID: tomhughes left a comment (openstreetmap/openstreetmap-website#6073) Really? So JOSM uses id tokens not just auth tokens? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6073#issuecomment-2927612475 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 17:47:32 2025 From: notifications at github.com (Marwin Hochfelsner) Date: Sun, 01 Jun 2025 10:47:32 -0700 Subject: [openstreetmap/openstreetmap-website] Inline SVGs with helper module (PR #5938) In-Reply-To: References: Message-ID: @hlfan pushed 7 commits. f8bd61518203286d3001da2b2899b43ea4a2db28 Make Rails handle SVG partials c82c39a043e9bec74d0b9b1e70299bf19c8e4f2c Move search icons to partials 324b27e9da5e5a9f1986e547b67295ba2db58ff7 Move about icons to partials 3b4f65c8081ae94d19a5ec978ac2aa79e4a07e53 Move welcome icons to partials a839e1743aaad6a8e1dbb2efc5cff3f8bbb721d8 Move diary icons to partials a01d2ae955315f7f41f458108b7f4092441da940 Move more icons to partials 08f39f5c330c750d5ba5e060c8cb99d759e1085b Move social link icons to partials -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5938/files/30bda2249e56b943c2581d1653488e9bfcb70a38..08f39f5c330c750d5ba5e060c8cb99d759e1085b You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 17:51:16 2025 From: notifications at github.com (mmd) Date: Sun, 01 Jun 2025 10:51:16 -0700 Subject: [openstreetmap/openstreetmap-website] JOSM can't use OAuth2 to connect to my local osm-website (Issue #6073) In-Reply-To: References: Message-ID: mmd-osm left a comment (openstreetmap/openstreetmap-website#6073) The issue is that JOSM requires the /.well-known/oauth-authorization-server endpoint to be around, and for some reason Doorkeeper disables this endpoint unless you define a doorkeeper_signing_key. That's mostly in place so that JOSM can more easily discover various OAuth2 endpoints, since they would be advertised by the oauth-authorization-server endpoint. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6073#issuecomment-2927614300 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 17:58:24 2025 From: notifications at github.com (Tom Hughes) Date: Sun, 01 Jun 2025 10:58:24 -0700 Subject: [openstreetmap/openstreetmap-website] JOSM can't use OAuth2 to connect to my local osm-website (Issue #6073) In-Reply-To: References: Message-ID: tomhughes left a comment (openstreetmap/openstreetmap-website#6073) Yes that's an OpenID Connect endpoint not an OAuth endpoint - no idea why JOSM wants to hit that because it's not necessary and I don't think it even existed when they first added OAUth 2 support. It doesn't strictly speaking need the signing key though one of the URLs it returns would. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6073#issuecomment-2927622454 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 18:08:04 2025 From: notifications at github.com (Marwin Hochfelsner) Date: Sun, 01 Jun 2025 11:08:04 -0700 Subject: [openstreetmap/openstreetmap-website] Stop tests from being run in french (Issue #6075) Message-ID: hlfan created an issue (openstreetmap/openstreetmap-website#6075) Lately I've seen multiple tests fail because the tests are expecting an English site but it's rendered in French. ```diff --- expected +++ actual @@ -1 +1 @@ -"building=yes, shop=gift, and tourism=museum" +"building=yes, shop=gift et tourism=museum" ``` ```diff --- expected +++ actual @@ -1 +1 @@ -"https://wiki.openstreetmap.org/wiki/Key:highway?uselang=en" +"https://wiki.openstreetmap.org/wiki/FR:Key:highway?uselang=fr" ``` ```diff --- expected +++ actual @@ -1 +1 @@ -"Active until the user logs in." +"Actif jusqu?? ce que l?utilisateur se connecte." ``` Any clue why the language preference isn't cleared? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6075 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 18:13:08 2025 From: notifications at github.com (Marwin Hochfelsner) Date: Sun, 01 Jun 2025 11:13:08 -0700 Subject: [openstreetmap/openstreetmap-website] Switch to inline colourable markers (PR #5854) In-Reply-To: References: Message-ID: hlfan left a comment (openstreetmap/openstreetmap-website#5854) Hey @AntonKhorev, when you get a chance, would love your eyes on this one if it?s not getting in the way of your daily PR -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5854#issuecomment-2927645268 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 18:26:39 2025 From: notifications at github.com (Tom Hughes) Date: Sun, 01 Jun 2025 11:26:39 -0700 Subject: [openstreetmap/openstreetmap-website] Stop tests from being run in french (Issue #6075) In-Reply-To: References: Message-ID: tomhughes left a comment (openstreetmap/openstreetmap-website#6075) I've seen Russian as well... Still looking into it but I don't think it's actually the language preference as such as all the new tests around that are changing the preference on a temporary user that won't last past the test. Plus I've seen it happen on helper tests which aren't even running against a logged in user. I think the real issue is around the `I18n.locale` global persisting across tests. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6075#issuecomment-2927654583 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 18:35:09 2025 From: notifications at github.com (Tom Hughes) Date: Sun, 01 Jun 2025 11:35:09 -0700 Subject: [openstreetmap/openstreetmap-website] Stop tests from being run in french (Issue #6075) In-Reply-To: References: Message-ID: tomhughes left a comment (openstreetmap/openstreetmap-website#6075) Yes there are four tests that leave `I18n.locale` set to `fr` and one that leaves it set to `ru` and if the next test is something like a helper test that doesn't call `set_locale` as part of running an action then it will run in that locale. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6075#issuecomment-2927669580 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 18:54:50 2025 From: notifications at github.com (mmd) Date: Sun, 01 Jun 2025 11:54:50 -0700 Subject: [openstreetmap/openstreetmap-website] JOSM can't use OAuth2 to connect to my local osm-website (Issue #6073) In-Reply-To: References: Message-ID: mmd-osm left a comment (openstreetmap/openstreetmap-website#6073) https://josm.openstreetmap.de/changeset/18991/josm talks about leveraging [RFC 8414](https://datatracker.ietf.org/doc/html/rfc8414) to determine authorization_endpoint and token_endpoint fields. I think that's more of a convenience feature so that users won't have to manually enter all these URLs. Enabling the OIDC endpoint was done as part of #4226, which was done about half a year before the JOSM commit. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6073#issuecomment-2927696197 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 19:05:51 2025 From: notifications at github.com (Marwin Hochfelsner) Date: Sun, 01 Jun 2025 12:05:51 -0700 Subject: [openstreetmap/openstreetmap-website] Reuse bounds size functions (PR #6076) Message-ID: Reuse more utilities instead of redoing from scratch. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6076 -- Commit Summary -- * Reuse error printing * Reuse bounds and size functions -- File Changes -- M app/assets/javascripts/index/query.js (25) M app/assets/javascripts/osm.js.erb (14) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/6076.patch https://github.com/openstreetmap/openstreetmap-website/pull/6076.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6076 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/openstreetmap-website/pull/6076 at github.com> -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 19:35:26 2025 From: notifications at github.com (Tom Hughes) Date: Sun, 01 Jun 2025 12:35:26 -0700 Subject: [openstreetmap/openstreetmap-website] Protect I18n.locale around tests which may change it (PR #6077) Message-ID: Avoid accidental changes to `I18n.locale` when a request is made as a logged in user with a different language preference. Fixes #6075. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6077 -- Commit Summary -- * Protect I18n.locale around tests which may change it -- File Changes -- M test/controllers/preferences/advanced_preferences_controller_test.rb (20) M test/controllers/preferences/basic_preferences_controller_test.rb (24) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/6077.patch https://github.com/openstreetmap/openstreetmap-website/pull/6077.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6077 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/openstreetmap-website/pull/6077 at github.com> -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 23:33:04 2025 From: notifications at github.com (Anton Khorev) Date: Sun, 01 Jun 2025 16:33:04 -0700 Subject: [openstreetmap/openstreetmap-website] Stop tests from being run not in English (Issue #6075) In-Reply-To: References: Message-ID: Closed #6075 as completed via d9b758267c169f29560c824dee81f8ace77de11d. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6075#event-17919472645 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 23:34:39 2025 From: notifications at github.com (Anton Khorev) Date: Sun, 01 Jun 2025 16:34:39 -0700 Subject: [openstreetmap/openstreetmap-website] Protect I18n.locale around tests which may change it (PR #6077) In-Reply-To: References: Message-ID: AntonKhorev left a comment (openstreetmap/openstreetmap-website#6077) Merged, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6077#issuecomment-2928116090 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 23:33:04 2025 From: notifications at github.com (Anton Khorev) Date: Sun, 01 Jun 2025 16:33:04 -0700 Subject: [openstreetmap/openstreetmap-website] Protect I18n.locale around tests which may change it (PR #6077) In-Reply-To: References: Message-ID: Merged #6077 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6077#event-17919472698 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 23:35:36 2025 From: notifications at github.com (Marwin Hochfelsner) Date: Sun, 01 Jun 2025 16:35:36 -0700 Subject: [openstreetmap/openstreetmap-website] Reuse bounds size functions (PR #6076) In-Reply-To: References: Message-ID: @hlfan pushed 2 commits. 12f9398b6d39d4e05e11f2c3897f7bfcfceb24d9 Reuse error printing 9db226ca03bd4a4c5cf09774aba5455a4ae94155 Reuse bounds and size functions -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6076/files/89b2d81e5b7f5d5bd1e424aabb9ffbfa349e930b..9db226ca03bd4a4c5cf09774aba5455a4ae94155 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 23:36:05 2025 From: notifications at github.com (Marwin Hochfelsner) Date: Sun, 01 Jun 2025 16:36:05 -0700 Subject: [openstreetmap/openstreetmap-website] Use only differences to OSM logo in internal social link icons (PR #6072) In-Reply-To: References: Message-ID: @hlfan pushed 1 commit. 58256f357c30676600354f975b85c2f5edfa3946 Use only differences to OSM logo in internal social link icons -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6072/files/ba8b9ed6d358880f38540cb8b6c2eb7c1ea54b51..58256f357c30676600354f975b85c2f5edfa3946 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 1 23:36:27 2025 From: notifications at github.com (Marwin Hochfelsner) Date: Sun, 01 Jun 2025 16:36:27 -0700 Subject: [openstreetmap/openstreetmap-website] Move html from javascript to views (PR #6063) In-Reply-To: References: Message-ID: @hlfan pushed 7 commits. db7905d9338d256f412fa9a12c1f6bbf2e0671d6 Write layer sidebar in erb template a11951a0b6210a0913a2638a1183ce8b69fa712e Write share sidebar in erb template 2e7df28874f87c4e92f4e51c2736fa8fcff2d6b2 Move layer sidebar translations f544258ce635be552152051138b0ad0d88e63c5d Move share sidebar translations bc8f6396ffba64476ad9ee39661457f241e4a81e Put key content class in erb and load content only once fdfadde56592cc97f630000d832613465b58dcf3 Add loadContent function to sidebarPane dbf14dbfd6b508731a83d47c138a9b8ad887593d Make event handler logic more terse -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6063/files/df161885e6f2cdec5f1ae6520aa831bea8d4c169..dbf14dbfd6b508731a83d47c138a9b8ad887593d You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jun 2 00:09:29 2025 From: notifications at github.com (Anton Khorev) Date: Sun, 01 Jun 2025 17:09:29 -0700 Subject: [openstreetmap/openstreetmap-website] Reuse bounds size functions (PR #6076) In-Reply-To: References: Message-ID: AntonKhorev left a comment (openstreetmap/openstreetmap-website#6076) What do you think `.wrap()` on `L.LatLngBounds` does? See https://github.com/openstreetmap/openstreetmap-website/pull/5473#issue-2770179737. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6076#issuecomment-2928172136 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jun 2 00:23:14 2025 From: notifications at github.com (Marwin Hochfelsner) Date: Sun, 01 Jun 2025 17:23:14 -0700 Subject: [openstreetmap/openstreetmap-website] Reuse bounds size functions (PR #6076) In-Reply-To: References: Message-ID: @hlfan pushed 1 commit. 47913851f0d57ab1068cfec90dda6920f86c5489 Reuse bounds and size functions -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6076/files/9db226ca03bd4a4c5cf09774aba5455a4ae94155..47913851f0d57ab1068cfec90dda6920f86c5489 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jun 2 00:23:45 2025 From: notifications at github.com (Marwin Hochfelsner) Date: Sun, 01 Jun 2025 17:23:45 -0700 Subject: [openstreetmap/openstreetmap-website] Reuse bounds size functions (PR #6076) In-Reply-To: References: Message-ID: hlfan left a comment (openstreetmap/openstreetmap-website#6076) Updated `.getSize()` so `.wrap()` isn't necessary anymore. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6076#issuecomment-2928189028 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jun 2 00:53:00 2025 From: notifications at github.com (Anton Khorev) Date: Sun, 01 Jun 2025 17:53:00 -0700 Subject: [openstreetmap/openstreetmap-website] Test sorting multiple enclosing features across antimeridian (PR #6078) Message-ID: #6076 as it currently is will fail this test. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6078 -- Commit Summary -- * Test sorting multiple enclosing features across antimeridian -- File Changes -- M test/system/query_features_test.rb (69) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/6078.patch https://github.com/openstreetmap/openstreetmap-website/pull/6078.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6078 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/openstreetmap-website/pull/6078 at github.com> -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jun 2 03:12:14 2025 From: notifications at github.com (Nick Doiron) Date: Sun, 01 Jun 2025 20:12:14 -0700 Subject: [openstreetmap/openstreetmap-website] Add lang attribute to Nominatim results from CJK languages (PR #6079) Message-ID: ### Description In Unicode, some CJK characters such as ? have one codepoint but will appear differently in Simplified Chinese (<span lang="zh-Hans">?</span>), Traditional Chinese (<span lang="zh-Hant">?</span>), and Japanese (<span lang="ja">?</span>). On the frontend, we can display names correctly using an HTML attribute such as `lang="zh-Hant"` This issue is known as [Han unification](https://en.wikipedia.org/wiki/Han_unification) and it has appeared over the years [in many software projects](https://issues.chromium.org/issues/41315603) This was addressed in iD https://github.com/openstreetmap/iD/pull/10716 and is a long-running discussion in openstreetmap-carto. If we add `&addressdetails=1` to Nominatim queries, we can read the country_code and display the best label for mainland China, Hong Kong, Japan, or Taiwan. ### How has this been tested? This can be tricky to test, as **many names do not change**, and the display_name will be in your browser's language if it's available - Search results will have a lang tag, such as `lang="zh-HK"` or `lang="ja"`, regardless of language of display_name - In Taiwan, a search result for <span lang="zh-Hant">??</span> should show a horizontal bar in <span lang="zh-Hant">?</span> - In mainland China, a search result for <span lang="zh-Hans">?? expressway</span> should return a split frame <span lang="zh-Hans">?</span> in the second character, not the ? with a + ### Notes As an alternative to adding `&addressdetails=1` to queries, we could possibly parse display_name (varies with the browser language) or use geo bounding boxes? This matching of languages is imperfect, but without a language tag we are always using your browser's default for any CJK character. It would be difficult to make exceptions (for example, Japanese restaurants in these countries) without a name regex, a language tag, or access to other tags This does not affect Chinese names in other countries I have heard that there are some variations for Cyrillic in [Bulgaria](https://en.wikipedia.org/wiki/Bulgarian_alphabet) and [Serbia](https://en.wikipedia.org/wiki/Serbian_Cyrillic_alphabet#Differences_from_other_Cyrillic_alphabets), particularly in italics? But I don't know how universal it is. [Additional info](https://commons.wikimedia.org/wiki/File:Special_Cyrillics_BGDPT.svg) You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6079 -- Commit Summary -- * add lang attribute to results from CJK countries, plus Cyrillic * remove Bulgaria/Serbia for now * fix HK subregion -- File Changes -- M app/controllers/concerns/nominatim_methods.rb (2) M app/controllers/searches/nominatim_queries_controller.rb (7) M app/helpers/geocoder_helper.rb (2) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/6079.patch https://github.com/openstreetmap/openstreetmap-website/pull/6079.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6079 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/openstreetmap-website/pull/6079 at github.com> -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jun 2 03:35:32 2025 From: notifications at github.com (Nick Doiron) Date: Sun, 01 Jun 2025 20:35:32 -0700 Subject: [openstreetmap/openstreetmap-website] Add lang attribute to Nominatim results from CJK languages (PR #6079) In-Reply-To: References: Message-ID: @mapmeld pushed 2 commits. b905080241450f94fb00a87e4479c22695f21ee3 nominatim stubs 84726db2e95ef0899021e3edbbb2dacc4a7ecb25 reverse geocoder -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6079/files/72a1995031f0ff809d977fcc933ffe7893da5530..84726db2e95ef0899021e3edbbb2dacc4a7ecb25 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jun 2 04:27:00 2025 From: notifications at github.com (=?UTF-8?B?TWluaCBOZ3V54buFbg==?=) Date: Sun, 01 Jun 2025 21:27:00 -0700 Subject: [openstreetmap/openstreetmap-website] Add lang attribute to Nominatim results from CJK languages (PR #6079) In-Reply-To: References: Message-ID: @1ec5 commented on this pull request. > @@ -12,6 +14,14 @@ def create # ask nominatim response = fetch_xml(nominatim_reverse_query_url(:format => "xml")) + # add lang attribute for frontend in certain regions + addressparts = response.elements["reversegeocode/addressparts"] + lang = nil + if addressparts + region_code = addressparts.elements["ISO3166-2-lvl3"]&.text == "CN-HK" ? "hk" : addressparts.elements["country_code"]&.text + lang = region_code ? LANGUAGE_CODES[region_code] : nil Does this assume the displayed name is always in Chinese if the result is from China? That could result in suboptimal font selection and unexpected screen reader behavior if the name is in a different language due to the interface language. Based on `extratags`, could we determine whether the display name is based on one of the preferred interface languages or falling back to `name=*`? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6079#pullrequestreview-2886672465 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jun 2 07:13:32 2025 From: notifications at github.com (Sarah Hoffmann) Date: Mon, 02 Jun 2025 00:13:32 -0700 Subject: [openstreetmap/openstreetmap-website] Add lang attribute to Nominatim results from CJK languages (PR #6079) In-Reply-To: References: Message-ID: @lonvia commented on this pull request. > @@ -12,6 +14,14 @@ def create # ask nominatim response = fetch_xml(nominatim_reverse_query_url(:format => "xml")) + # add lang attribute for frontend in certain regions + addressparts = response.elements["reversegeocode/addressparts"] + lang = nil + if addressparts + region_code = addressparts.elements["ISO3166-2-lvl3"]&.text == "CN-HK" ? "hk" : addressparts.elements["country_code"]&.text + lang = region_code ? LANGUAGE_CODES[region_code] : nil You cannot make such assumptions. Nominatim decides for each part of the display name separately which translation fits best. Consequently, this whole guessing here will go wrong if a user with Japanese language settings searches something in China and gets a result which is mixed Chinese/Japanese. It's also not clear to me, if a Japanese reader would rather expect Japanese han even in the Chinese-language parts or if that would only be the case when they are able to read the different han versions. Sounds to me like it is worth tackling language-tagging of the display name in Nominatim instead of making educated guesses here. We currently have a GSoC project running for transliteration of display names. Language-tagging will be a part of that. Should be feasible to return that information. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6079#discussion_r2120256570 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jun 2 11:31:47 2025 From: notifications at github.com (Mahmoud Hanafy) Date: Mon, 02 Jun 2025 04:31:47 -0700 Subject: [openstreetmap/openstreetmap-website] JOSM can't use OAuth2 to connect to my local osm-website (Issue #6073) In-Reply-To: References: Message-ID: mahmoudhanafy left a comment (openstreetmap/openstreetmap-website#6073) Thanks for your response. I have another question, not related to this issue. but appreciate if you can reply. Are there versions for openstreetmaps-website? I mean like stable versions that can be used instead of using the the latest master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6073#issuecomment-2930169415 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jun 2 11:36:03 2025 From: notifications at github.com (mmd) Date: Mon, 02 Jun 2025 04:36:03 -0700 Subject: [openstreetmap/openstreetmap-website] JOSM can't use OAuth2 to connect to my local osm-website (Issue #6073) In-Reply-To: References: Message-ID: mmd-osm left a comment (openstreetmap/openstreetmap-website#6073) https://github.com/openstreetmap/openstreetmap-website/issues/5950#issuecomment-2830201587 has some previous discussion on this topic. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6073#issuecomment-2930183946 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jun 2 11:48:13 2025 From: notifications at github.com (Tom Hughes) Date: Mon, 02 Jun 2025 04:48:13 -0700 Subject: [openstreetmap/openstreetmap-website] JOSM can't use OAuth2 to connect to my local osm-website (Issue #6073) In-Reply-To: References: Message-ID: tomhughes left a comment (openstreetmap/openstreetmap-website#6073) No there are no versions because we're only really concerned about building the code for openstreetmap.org and if people want to use it for other things then that's up to them but we don't need versioned releases for our purposes. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6073#issuecomment-2930274226 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jun 2 13:17:05 2025 From: notifications at github.com (Anton Khorev) Date: Mon, 02 Jun 2025 06:17:05 -0700 Subject: [openstreetmap/openstreetmap-website] Remove "preferences updated" flash fallback to old message (PR #6080) Message-ID: It was necessary for tests relying on old French message before getting an update from Translatewiki. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6080 -- Commit Summary -- * Remove "preferences updated" flash fallback to old message -- File Changes -- M app/views/preferences/preferences/_update_success_flash.html.erb (6) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/6080.patch https://github.com/openstreetmap/openstreetmap-website/pull/6080.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6080 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/openstreetmap-website/pull/6080 at github.com> -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jun 2 13:28:46 2025 From: notifications at github.com (Anton Khorev) Date: Mon, 02 Jun 2025 06:28:46 -0700 Subject: [openstreetmap/openstreetmap-website] Make "W" in osm wiki social icon more readable (PR #6065) In-Reply-To: References: Message-ID: AntonKhorev left a comment (openstreetmap/openstreetmap-website#6065) How about this: - no "iki" in microscopic font size (#6072 still wants it) - two icons for osm for osm subdomains, like this: (forum icon).(osm logo) - similarly two icons for ohm and ogf subdomains -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6065#issuecomment-2930730330 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jun 2 14:05:43 2025 From: notifications at github.com (Anton Khorev) Date: Mon, 02 Jun 2025 07:05:43 -0700 Subject: [openstreetmap/openstreetmap-website] Add locale selector (PR #5201) In-Reply-To: References: Message-ID: @AntonKhorev commented on this pull request. > + After #6024 this can be replaced with ```suggestion <%= select_tag "language", options_for_select(AVAILABLE_LANGUAGES.map { |e| [e[:native_name], e[:code]] }, I18n.locale), :role => "button", :class => "p-0 position-absolute top-0 start-0 w-100 h-100 language-change-trigger text-transparent bg-transparent #{classes}" %> ``` https://github.com/AntonKhorev/openstreetmap-website/tree/a/pull/5201 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5201#discussion_r2121255541 You are receiving this because you are subscribed to this thread. Message ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jun 2 14:07:18 2025 From: notifications at github.com (Anton Khorev) Date: Mon, 02 Jun 2025 07:07:18 -0700 Subject: [openstreetmap/openstreetmap-website] Add locale selector (PR #5201) In-Reply-To: References: Message-ID: @AntonKhorev commented on this pull request. > @@ -0,0 +1,15 @@ +