[openstreetmap/openstreetmap-website] [notes API] Prevent duplication of the same note with equal coordinates and text (Issue #6100)
Alexander Borsuk
notifications at github.com
Sat Jun 14 16:02:28 UTC 2025
biodranik left a comment (openstreetmap/openstreetmap-website#6100)
Thanks for the reference to a similar #2201 issue. I read comments there, and do not understand why this (and that) issue was closed:
1. #2201 was closed just because nobody commented there. The problem of duplication in the database has not been solved yet, right? Why close both issues? Before creating this one, I was looking for something related and didn't find anything.
2. How many duplicated data (excluding notes) are now in the OSM database? Is it still an issue? With notes, it is an annoying issue because they are resolved manually by people. Here are some stats https://dupnotes.webmapping.cyou/ with a [subset of Organic Maps duplicated notes](https://dupnotes.webmapping.cyou/organic-maps/om-dupe-notes.json). So it is still an issue.
3. How do you propose to solve it on a client without changes on the server? Query the data first before creating a note? That will double the HTTP server load. Clients are losing network connection frequently, as was mentioned already many times. This is the reality.
4. #2201 discusses different _complex_ approaches to solve the problem on a server or server+client side, and I agree with @tomhughes that proposed solutions there are _too complex_ to implement.
5. I did not check the current OSM notes DB schema and don't know the current typical server load (if it is a bottleneck already). @tomhughes is it expensive to compare coordinates+text from a note create request with content in the DB before actually creating a record, without storing/modifying the database with any hashes? Or use coords+initial note text as a unique index in the DB?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6100#issuecomment-2972847642
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/issues/6100/2972847642 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250614/0b3b95de/attachment-0001.htm>
More information about the rails-dev
mailing list